-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support: config + workflow to catch new typos, let it fix some #1392
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 32 32
Lines 2132 2132
=======================================
Hits 2080 2080
Misses 52 52 ☔ View full report in Codecov by Sentry. |
640fd44
to
2c98793
Compare
@yarikoptic is this still a draft? |
29adfbd
to
d77c471
Compare
I moved it into draft since was experimenting with fixing that typo in a url in a test -- tests pass so it is great -- we can just fix the test. Also we verified that pre-commit catches typos -- I will remove dedicated workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I'm a little uncomfortable with changing names of variables in code (split -> splitted) but I guess in this case it's not a problem.
Please add yourself to AUTHORS
Includes also squashed - [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci - Unfortunately due to bug in codespell we need to duplicate some skipped paths for pre-commit config
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Description of the Change
https://github.com/codespell-project/codespell is great to catch typos
Let me know if needs changelog entry etc
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS